Do not redirect index.html to / #13729
Conversation
|
started the job as gitpod-build-jp-fix-redirect.1 because the annotations in the pull request description changed |
jeanp413
force-pushed
the
jp/fix-redirect
branch
3 times, most recently
from
b7a304a to
faad99e
Compare
mustard-mh
left a comment
mustard-mh
left a comment
There was a problem hiding this comment.
Code LGTM, going to test it
|
2nd request (see before image) has gone and webView/VSCode works well
|
|
question (non-blocking): @jeanp413 so this means that in the case for @mustard-mh (see first screenshot), the experience should be smoother? Should it be 239ms faster to open? 👀 |
| if resourcePath == "/" { | ||
| resourcePath = "/index.html" | ||
| } | ||
| if strings.HasSuffix(resourcePath, "index.html") { |
There was a problem hiding this comment.
[non-block] aindex.html is included, but it's fine
There was a problem hiding this comment.
/hold if you want to change it
@filiptronicek Yes, it can remove one useless request |
jeanp413
force-pushed
the
jp/fix-redirect
branch
from
faad99e to
d5dd29b
Compare
|
/unhold |
roboquat
added
deployed: IDE
Description
Do not redirect index.html to /
Related issues
How to test
out/vs/workbench/contrib/webview/browser/pre/index.htmltoout/vs/workbench/contrib/webview/browser/pre/Release Notes
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide